fix(android): crash on New Architecture in trackDeepLinks#1146
Merged
abueide merged 1 commit intoJun 12, 2026
Merged
Conversation
trackDeepLinks() accessed SovranModule through the old ReactNativeHost chain (ReactApplication -> reactNativeHost -> reactInstanceManager -> currentReactContext -> getNativeModule), which throws a RuntimeException on React Native's New Architecture (Bridgeless mode): "You should not use ReactNativeHost directly in the New Architecture" The fix uses reactApplicationContext.getNativeModule() directly, which is the same pattern already used by setAnonymousId() in this class. Also removes unused ReactApplication and ReactActivity imports.
mohit-ranjan-25
approved these changes
Apr 23, 2026
|
This looks good to me, can any maintainer have a look as well? |
Contributor
Author
|
Fix for #1147 |
15 tasks
|
is there any maintainer to give this small PR a review? |
This was referenced Jun 1, 2026
abueide
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Crash on Expo 55
trackDeepLinks()inAnalyticsReactNativeModule.ktaccessesSovranModulethrough the oldReactNativeHostchain:This throws a
RuntimeExceptionon React Native's New Architecture (Bridgeless mode):The crash happens on every app launch (
onHostResume) and on deep links (onNewIntent).Fix
Use
reactApplicationContext.getNativeModule()directly